ExeReader: Support 64 Bit executables #3317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdelapena
approved these changes
Dec 21, 2024
carstene1ns
reviewed
Dec 22, 2024
Maniac Patch is now detected when the new exe is used. The difference between 32bit PE and 64 bit PE is actually not that huge when you only care about the resources. The differences: - The machine type is 0x8664 - In the optional header the magic at the beginning is 0x20b instead of 0x10b (0x20b is a "PE32+" header, 0x10b is a "PE32" header) - The data direction offset is different because the PE32+ image file header is larger The offset calculation was the major change: Before the resource offset was hardcoded to 0x88 (136) which is actually "size_of_optional_header (24) + size_of_image_file_header (96/112 [PE+]) + 16".
carstene1ns
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maniac Patch is now detected when the new exe is used.
The difference between 32bit PE and 64 bit PE is actually not that huge when you only care about the resources.
The differences:
The offset calculation was the major change:
Before the resource offset was hardcoded to
0x88(136) which is actuallysize_of_optional_header (24) + size_of_image_file_header (96/112 [PE+]) + 16.All the resource format itself is the same. (lucky for us).
Tested it with:
Player.exe, both 32 Bit and 64 Bit: PASSED
Maniac exe: PASSED
Various RPG_RT (32 bit): PASSED