-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Zenburn, and 2 OCaml extensions #131
Conversation
Thanks for the contribution!
Generally it would be good to add |
Indeed vscode-reasonml is deprecated and doesn't work with recent versions of OCaml anymore, I removed it from this PR. |
A license file has been added for hc-zenburn-vscode, and I've added a checkout property for ocamllabs.ocaml-platform, so hopefully this PR is good to go now? (hc-zenburn-vscode has no tags, so I could only add a hash as checkout, not sure if that'd be useful) |
@drzix chose GPL-3.0 for hc-zenburn-vscode. Unfortunately that license is not compatible with requirements of the Eclipse Foundation at this moment, see #49 (comment). @edwintorok could you remove that extension from this PR? We might be able to include GPL licensed extensions at some point, for now we should stick with the current requirements. |
ISC licensed
MIT Signed-off-by: Edwin Török <[email protected]>
I intended to use hc-zenburn-vscode with Codium which is MIT licensed and therefore compatible with GPL3. It'd be nice if open-vsix had a way of accepting GPL3 extensions for the purposes of Codium (and hide it from Eclipse if it has to). Anyway I've replaced that plugin with another one that is MIT licensed (it is not the high-contrast version). |
I agree. We might get back to this in case the requirements will change. |
Update: Auto-publishing worked! 🎉
I agree as well. FYI, we're currently investigating a solution that could potentially allow any open-source license onto OpenVSX. If it works, you can expect more news on that in a few weeks. |
* Add ocamllabs.ocaml-platform (ISC licensed) * Add ryanolsonx.zenburn (MIT)
No description provided.