Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JannisX11.batch-rename #723

Closed
wants to merge 1 commit into from
Closed

Conversation

stocyr
Copy link

@stocyr stocyr commented Nov 29, 2023

  • I have read the note above about PRs contributing or fixing extensions
  • I have tried reaching out to the extension maintainers about publishing this extension to Open VSX (if not, please create an issue in the extension's repo using this template): see the PR here.
  • This extension has an OSI-approved OSS license (we don't accept proprietary extensions in this repository): MIT

Description

Added JannisX11.batch-rename

@filiptronicek
Copy link
Member

Hi @stocyr 👋, thanks for the contribution. It seems that https://github.com/JannisX11/batch-rename does not use tags / releases, which does not sit well with our publishing system. Since the extension seems inactive, I will publish this manually and hopefully its author can publish subsequent releases.

@filiptronicek
Copy link
Member

It seems that the build process is broken. @stocyr have you been able to package it yourself?

@filiptronicek filiptronicek added the changes-requested Waiting for an update label Dec 15, 2023
@stocyr
Copy link
Author

stocyr commented Dec 15, 2023

@filiptronicek I didn't try to package it yet.

@filiptronicek
Copy link
Member

@stocyr sadly I cannot get a working version of the extension myself and therefore cannot merge this PR now. Could you please mark it as a draft or close it until we have a way to build it? 🙏

@stocyr
Copy link
Author

stocyr commented Jan 5, 2024

I forked the original project and updated a few dependencies -- got it to build successfully on my own fork.

A PR is already filed, I hope the author reacts on it. Otherwise I suggest I publish my fork instead.

@filiptronicek
Copy link
Member

@stocyr I am glad you have built it successfully on your fork. I will try packaging it myself and publishing it from there. In this case, I'm happy to publish under the original namespace of JannisX11, but I would also be happy if you'd like to publish it yourself under your own.

@stocyr
Copy link
Author

stocyr commented Jan 9, 2024

@filiptronicek I suggest publishing under Jannis' namespace. I didn't really add anything to it honestly.

@stocyr
Copy link
Author

stocyr commented Jan 9, 2024

@filiptronicek I just noticed that during our efforts, this repo already created a copy (no fork, just a blank new commit) which independently published Batch-Rename to Open VSX..

Its required engine version is quite strict however (1.84.0). But publishing a duplicate is even less optimal.

@filiptronicek
Copy link
Member

@stocyr it seems that although the name and icon are the same, the code is different, or at least added to. I think it still makes sense to publish the one you packaged, as one-time publishing will be useful for folks migrating from the VS Code Marketplace via ids.

Its required engine version is quite strict however (1.84.0)

Since we are past the 1.85 release and the self-updating nature of VS Code, I wouldn't see this as too much of a problem.

@filiptronicek
Copy link
Member

filiptronicek commented Jan 12, 2024

I've published it now: https://open-vsx.org/extension/JannisX11/batch-rename-extension

Please let me know if there's anything else. Otherwise, I'm closing this, and thanks again for your contribution 🙏.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes-requested Waiting for an update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants