Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cdt-gdb-vscode from auto-publish #813

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Remove cdt-gdb-vscode from auto-publish #813

merged 1 commit into from
Jan 20, 2025

Conversation

jreineckearm
Copy link
Contributor

  • I have read the note above about PRs contributing or fixing extensions
  • I have tried reaching out to the extension maintainers about publishing this extension to Open VSX (if not, please create an issue in the extension's repo using this template).
  • This extension has an OSI-approved OSS license (we don't accept proprietary extensions in this repository)

Description

With eclipse-cdt-cloud/cdt-gdb-vscode#130 , we have introduced GitHub actions to directly publish to Open VSX. Before we make our first release with the new process, we would like to remove this extension from being auto-published.

CC: @jonahgraham, @thegecko, @spoenemann

thegecko
thegecko approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@thegecko thegecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

filiptronicek
filiptronicek approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! 🚀

@filiptronicek filiptronicek merged commit 85f5beb into EclipseFdn:master Jan 20, 2025
2 checks passed
@jreineckearm jreineckearm deleted the remove-cdt-gdb-vscode-from-autopublish branch January 20, 2025 15:03
@jreineckearm jreineckearm mentioned this pull request Jan 20, 2025
Open
@jreineckearm
Copy link
Contributor Author

Thanks!

@jreineckearm jreineckearm mentioned this pull request Jan 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filiptronicek filiptronicek filiptronicek approved these changes

@thegecko thegecko thegecko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jreineckearm @thegecko @filiptronicek