Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tooltip support #155

Closed
wants to merge 1 commit into from
Closed

add tooltip support #155

wants to merge 1 commit into from

Conversation

mohsen77sk
Copy link

No description provided.

@PowerKiKi
Copy link
Member

If you are trying to add tooltip, then you can already have standard tooltips on each button when mouse is hovering, without any modification to this lib.

On the other hand, if you are trying to solve #5, and add labels, then tooltip is probably not the right tool. As you can see in the video below tooltips will act as tooltip and appear/disappear on hover. That looks severly broken and is not what we expect from label.

blinking-tooltips.mp4

Also it does not match the material spec design:

image

I'll be closing this PR for now, but feel free to re-open a PR if you are willing to add support for labels, not tooltips, that follow the spec and that is covered by unit tests.

@PowerKiKi PowerKiKi closed this Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants