Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Main #3282

Merged
merged 11 commits into from
Dec 6, 2023
Merged

Main #3282

merged 11 commits into from
Dec 6, 2023

Conversation

pxlmastrXD
Copy link
Contributor

What changes does this PR do?

Added my name to the contributors file.

Copy link

github-actions bot commented Nov 7, 2023

This repository is for practice only and therefore it will not count towards hacktoberfest.

@pxlmastrXD
Copy link
Contributor Author

okay

CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Member

@SaraJaoude SaraJaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we can maintain consistency and ease of navigation, please arrange your name alphabetically. This includes meticulously considering each letter's position, starting from the first and extending to the second, third, and so on.
Thanks!

@pxlmastrXD
Copy link
Contributor Author

Sorry, I am confused by what that means. Can I hear more so I can understand better?

@pxlmastrXD
Copy link
Contributor Author

Okay, I finished. Sorry for the confusion, I didn't see the names in the README file.

Fixed name positioning
@SaraJaoude
Copy link
Member

Okay, I finished. Sorry for the confusion, I didn't see the names in the README file.

Thanks for adding your name alphabetically.

You have also made changes to this file CONTRIBUTING.md which are not necessary, please can you remove these.

@pxlmastrXD
Copy link
Contributor Author

Alright! I have some bug here where I can't revert commits, so I just copied-and-pasted the current Contributing.md file into my branch. Thanks for putting up with me and my antics! I have never done a pull request before.

@schmelto schmelto merged commit 3246b2a into EddieHubCommunity:main Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants