Use max of 6 decimals for xrp dex #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullinator
force-pushed
the
paul/xrpMaxDecimals
branch
from
e5ae45e to
d1d51f3
Compare
Jon-edge
approved these changes
Nov 8, 2023
| @@ -43,6 +43,7 @@ const RIPPLE_SERVERS_DEFAULT = ['wss://s2.ripple.com'] | |||
| const EXCHANGE_INFO_UPDATE_FREQ_MS = 60000 | |||
| const VOLATILITY_SPREAD_DEFAULT = 0.0075 | |||
| const DUMMY_XRP_ADDRESS = 'rfuESo7eHUnvebxgaFjfYxfwXhM2uBPAj3' | |||
| const MAX_DECIMALS_MULTIPLIER = 1000000 | |||
There was a problem hiding this comment.
Is there some reason to separate this from ripple's currencyInfo.denominations[0].multiplier?
Jon-edge
approved these changes
Nov 8, 2023
paullinator
force-pushed
the
paul/xrpMaxDecimals
branch
from
d1d51f3 to
3b3fdb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none