Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paul/swap rune #305

Merged
merged 8 commits into from
Nov 21, 2023
Merged

Paul/swap rune #305

merged 8 commits into from
Nov 21, 2023

Conversation

paullinator
Copy link
Member

@paullinator paullinator commented Nov 11, 2023

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Description

none

Sorry, something went wrong.

@@ -571,11 +576,18 @@ export function makeThorchainPlugin(

let preTx: EdgeTransaction | undefined
if (approvalData != null) {
approvalData = approvalData.replace('0x', '')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: do this where it's defined

@@ -560,9 +564,10 @@ export function makeThorchainPlugin(
nativeAmount: fromNativeAmount
})
} else {
memo = '0x' + Buffer.from(memo).toString('hex')
memo = Buffer.from(memo).toString('hex')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: Replace buffer.from toString pattern with base16 from rfc4648

@paullinator paullinator merged commit f8aa4c1 into master Nov 21, 2023
@paullinator paullinator deleted the paul/swapRune branch November 21, 2023 02:10
@paullinator paullinator restored the paul/swapRune branch November 21, 2023 02:12
@paullinator paullinator deleted the paul/swapRune branch November 21, 2023 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants