Paul/upgrade core2.0 #309
Merged
Paul/upgrade core2.0 #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
approved these changes
Dec 20, 2023
src/swap/changehero.ts
Outdated
Comment on lines
318
to
327
| destAsset: { | ||
| pluginId: request.toWallet.currencyInfo.pluginId, | ||
| tokenId: request.toTokenId, | ||
| nativeAmount: amountExpectedToNative | ||
| }, | ||
| sourceAsset: { | ||
| pluginId: request.fromWallet.currencyInfo.pluginId, | ||
| tokenId: request.fromTokenId, | ||
| nativeAmount: amountExpectedFromNative | ||
| }, |
There was a problem hiding this comment.
Not a request for change, but more of an "oops, oh well":
The swap request uses the terms "from" and "to", but the swap action uses the terms "dest" and "source". It might have been sweeter to do fromAsset: EdgeAsset and toAsset: EdgeAsset in the swap action types, since it's not only shorter but also matches the existing naming.
|
Added commit to rename source/dest to to/fromAsset. |
|
Do not merge until edge-core-js 2.0 is published and this PR is modified to upgrade core |
paullinator
force-pushed
the
paul/upgradeCore2.0
branch
from
4f8db07 to
e262ece
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none