Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cpn): Play radio-generated audio in global/special function editor #3910

Merged
merged 2 commits into from
Sep 4, 2023
Merged

feat(cpn): Play radio-generated audio in global/special function editor #3910

merged 2 commits into from
Sep 4, 2023

Conversation

elecpower
Copy link
Collaborator

@elecpower elecpower commented Aug 6, 2023 •
edited
Loading

Fixes #3697

Summary of changes:

  • add system sounds to resources using parameter index with '.wav' extension as file name
  • display play/stop button when Play Sound function selected

Screenshot from 2023-08-09 16-53-53

@elecpower elecpower added enhancement ✨ New feature or request companion Related to the companion software labels Aug 6, 2023
@elecpower elecpower marked this pull request as draft August 6, 2023 12:32
@elecpower elecpower marked this pull request as ready for review August 8, 2023 20:45
@elecpower elecpower changed the title Companion allow playing sounds in global and special functions editor enh(cpn): allow playing sounds in global and special functions editor Aug 8, 2023
@elecpower elecpower changed the title enh(cpn): allow playing sounds in global and special functions editor enh(cpn): allow playing radio sounds eg beep in global and special functions editor Aug 9, 2023
@pfeerick pfeerick changed the title enh(cpn): allow playing radio sounds eg beep in global and special functions editor feat(cpn): Allow playing radio generated sounds in global/special functions editor Aug 16, 2023
@pfeerick pfeerick changed the title feat(cpn): Allow playing radio generated sounds in global/special functions editor feat(cpn): Play radio-generated audio in global/special function editor Aug 16, 2023
@elecpower elecpower force-pushed the elecpower/cpn-enh-3697-play-sounds branch from d8667f7 to afb3430 Compare August 29, 2023 11:14
@pfeerick pfeerick added this to the 2.10 milestone Sep 2, 2023
@pfeerick pfeerick self-requested a review September 2, 2023 09:49
@pfeerick
Copy link
Member

pfeerick commented Sep 4, 2023 •
edited
Loading

Specifically tested SFs with pre-existing models for TX16S and a new model for Boxer on Windows 11, worked flawlessly. Thanks Neil! :)

@pfeerick pfeerick merged commit d3ed7c1 into main Sep 4, 2023
3 checks passed
@elecpower elecpower deleted the elecpower/cpn-enh-3697-play-sounds branch September 8, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfeerick pfeerick Awaiting requested review from pfeerick

Assignees
No one assigned
Labels
companion Related to the companion software enhancement ✨ New feature or request
Projects
None yet
Milestone
2.10
Development

Successfully merging this pull request may close these issues.

Make Play Sound playable in Companion
2 participants
@elecpower @pfeerick