-
-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add trainer virtual switch #3937
Conversation
Is there any need to write this to yaml as I interpret it as being a condition and there is no need for persistence? |
Use cases help my understanding. Therefore if
then should the switch not be listed/available when trainer mode set to slave? |
I wondered about that too, but I felt there was more risk of confusion if a switch was to disappear based on trainer setup (especially in mixers lines). If you are slave, it will just never come true, but remains valid nonetheless |
8afac39
to
8992dd5
Compare
I tried the hard-wired trainer on X9D+2019, TX16S and Zorro, with a special function that beeps while the trainer is active... worked perfectly, as well as companion read/write. So now I get some form of audio prompt when the trainer connects, while it's active, and when it disconnects (if the audio files are present). I just had a thought... we protect the user against being able to power down while USB connected or a telemetry RF link active... but not with the trainer active? Something to think about? |
Asked for on RCGroups
This provide a virtual switch indicating when a trainer link is active.
The switch is functionality does not depend of trainer type (all work), and can only be ON on the master radio (as the slave radio has no way to know if a master is listening to it)