fix(el18): SWB and SWD swapped #4714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm... #4699 🤔 |
pfeerick
changed the title
Oops, I missed it, sorry. Anyway, I have made more description about the problem and the root cause. |
|
LGTM on 2xEL18 and 1xNV14 |
pfeerick
pushed a commit
that referenced
this pull request
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is due to the change in this PR:
#3779
when Raphael tested the firmware with his EL18, he found that the SWB and SWD is swapped, so he change the mapping in the above PR.
However, it is found that there are chances that the ext ADC will randomly shift channel when working out the PL18EV target, and this problem is due to improper handling of DMA, and is fixed in the following PR:
#4563
Now, I have received a few users reporting the same SWB/SWD swapped and after checking with Flysky. they confirms the 2.10.0-RC1 has this problem.
This PR restores the correct mapping of SWB and SWD.