chore: improve VBAT measurement #5635
Merged
+23
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depends by what you mean by a whole lot... 1V of movement seems like a lot for me 🤪 i.e. T-Pro jumped from 7.82 to 8.92V, but T12-Max and Zorro were a lot less - T12-Max from 7.79 to 8.12, and Zorro from 7.95 to 7.69. X9D+2019 was correctly non-affected. I completely agree, having the calculated value rather than a magic number is much better, and is more flexible for future variations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup of VBAT measurement definition for Radiomaster and Jumper radio where we have exact drawings and resistors values. This will break existing calibration (likely not by a whole lot), but overall I think it is for the best. In most cases, default value should already be very accurate