Adds support for ExpressLRS added optional arming method #5641
Conversation
…ing (legacy) and SF Arm arming (new)
… version that allows SF ARM
…ing. If SF Arm is not defined system will use ch5 logic for arming.
…and arming command message. This ensures the arming status is sent periodically and at the same rate as channel 5.
…annels packet adds extra byte to the RC channels message in arming mode Function: - frame len 24 -> arming mode Channel: module will use channel 5 - frame len 25 -> arming mode Function: send commanded armed status in extra byte after channel data
|
Great new functionality! |
pfeerick
added
enhancement ✨
|
This seems to be designed as CRSF specific, but is only tied to ELRS. How about adding "ELRS" to all labels to improve UX? I'm not EdgeTX advocate nor involved as developer/UX designer but I don't like how ELRS configuration must be done in many places (lua, specific module configuration, specific special function) where all of this can be kept in lua. I know historically MPM is also integrated in EdgeTX but because there was no lua by the time and other constraints. Now, there is better way, so i don't think it is the way to go nor user friendly. I'm not against your change, I just see other path that could be considered by project maintainers to make both projects better. |
This PR adds support for ExpressLRS/ExpressLRS#3008
Changes:
For more details please refer to ExpressLRS PR #3008