Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(color): unable to turn off radio if powered on with no SD card. #5893

Merged
merged 1 commit into from
Feb 11, 2025
Merged

fix(color): unable to turn off radio if powered on with no SD card. #5893

merged 1 commit into from
Feb 11, 2025

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented Feb 11, 2025

Fixes #5891

@philmoz philmoz added bug 🪲 Something isn't working color Related generally to color LCD radios UX-UI Related to user experience (UX) or user interface (UI) behaviour labels Feb 11, 2025
@philmoz philmoz added this to the 2.11 milestone Feb 11, 2025
@pfeerick pfeerick added bug/regression ↩️ A new version of EdgeTX broke something and removed bug 🪲 Something isn't working labels Feb 11, 2025
pfeerick
pfeerick approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@pfeerick pfeerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on TX16S and NV14

@pfeerick pfeerick merged commit 9a4b462 into main Feb 11, 2025
51 checks passed
@pfeerick pfeerick deleted the philmoz/fix-no-sd-card branch February 11, 2025 23:48
@pfeerick
Copy link
Member

Correction - NV14 (and el18?) may not be shutting down correctly - it will go through the motions, but will not power back up again without cycling the batteries. For now I'm simply going to crosslink #2794 as this is most likely nv14/el18 specific.

pfeerick pushed a commit that referenced this pull request Feb 12, 2025
@philmoz @pfeerick
fix(color): unable to turn off radio if powered on with no SD card (#…
34847c7 
…5893)
@pfeerick pfeerick mentioned this pull request Feb 12, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfeerick pfeerick pfeerick approved these changes

Assignees
No one assigned
Labels
bug/regression ↩️ A new version of EdgeTX broke something color Related generally to color LCD radios UX-UI Related to user experience (UX) or user interface (UI) behaviour
Projects
None yet
Milestone
2.11
Development

Successfully merging this pull request may close these issues.

Unable to turn off radio if powered on with no SD card.
2 participants
@philmoz @pfeerick