chore(bw): cleanup and consolidate B&W navigation code. #5896
+132
−208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philmoz
added
B&W
|
@pfeerick what MCU does the MT12 have? |
|
STM32F407 |
|
@gagarinlg so the MT12 should support 3.0? |
|
Will, not should be. 2.11 is the last release for STM32F2, not STM32F4. 3.0 will be dropping support for new STM32F MCU hardware to encourage use of newer, more capable hardware. Existing STM32F4s will continue be supported for as long as possible. Since it is actually a STM32F407xG (that last letter is important, as it means it has 1MB flash, not 512K like the E variant), this means it should have a longer life than some of it's other F4 bretherin... (sorry Zorro, Pocket 😢 ) |
|
@pfeerick that makes sense! I am pleased to know that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move most of the configuration for the different B&W navigation types into the navigation code files.
This PR focuses on the KEY navigation variations, to hopefully make future changes easier to manage.
There are a few other places where NAVIGATION_X7 is being used to control how the UI is displayed.
These may be able to be cleaned up in future.
Not sure if this will be needed for 2.11 or can wait for 3.0.