Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deviceShifu LwM2M Implement #1001

Merged
merged 12 commits into from
Oct 15, 2024
Merged

deviceShifu LwM2M Implement #1001

merged 12 commits into from
Oct 15, 2024

Conversation

rhoninl
Copy link
Collaborator

@rhoninl rhoninl commented Oct 12, 2024

What this PR does / why we need it:
deviceShifu LwM2M Implement
Will this PR make the community happier?
yes
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

How is this PR tested

  • unit test
  • e2e test
  • other (please specify)
    test by connect leshan
    Special notes for your reviewer:
    Test will finished in Issue Test for deviceShifu LwM2M #1013
    Release note:

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 399 lines in your changes missing coverage. Please review.

Project coverage is 33.37%. Comparing base (1d41155) to head (d81d8b5).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
pkg/deviceshifu/deviceshifulwm2m/lwm2m/lwm2m.go 0.00% 207 Missing ⚠️
...g/deviceshifu/deviceshifulwm2m/deviceshifulwm2m.go 0.00% 134 Missing ⚠️
pkg/k8s/api/v1alpha1/zz_generated.deepcopy.go 0.00% 32 Missing ⚠️
.../deviceshifu/deviceshifulwm2m/lwm2m/ciphersuite.go 0.00% 14 Missing ⚠️
...ceshifu/deviceshifulwm2m/deviceshifulwm2mconfig.go 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1001      +/-   ##
==========================================
- Coverage   37.60%   33.37%   -4.23%     
==========================================
  Files          46       50       +4     
  Lines        2976     3377     +401     
==========================================
+ Hits         1119     1127       +8     
- Misses       1737     2132     +395     
+ Partials      120      118       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rhoninl rhoninl force-pushed the deviceshifu_lwM2M branch 3 times, most recently from 670d499 to dc197eb Compare October 12, 2024 03:28
@rhoninl rhoninl force-pushed the deviceshifu_lwM2M branch 5 times, most recently from 06f42b3 to 885e033 Compare October 12, 2024 04:01
@rhoninl rhoninl marked this pull request as ready for review October 12, 2024 04:05
Copy link
Contributor

@tomqin93 tomqin93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhoninl added some comments, please take a look

dockerfiles/Dockerfile.deviceshifuLwM2M Outdated Show resolved Hide resolved
examples/lwm2mdeviceShifu/lwm2m-edgedevice.yaml Outdated Show resolved Hide resolved
pkg/deviceshifu/deviceshifulwm2m/deviceshifulwm2m.go Outdated Show resolved Hide resolved
pkg/deviceshifu/deviceshifulwm2m/deviceshifulwm2m.go Outdated Show resolved Hide resolved
pkg/deviceshifu/deviceshifulwm2m/deviceshifulwm2m.go Outdated Show resolved Hide resolved
pkg/deviceshifu/deviceshifulwm2m/lwm2m/ciphersuite.go Outdated Show resolved Hide resolved
pkg/deviceshifu/deviceshifulwm2m/lwm2m/ciphersuite.go Outdated Show resolved Hide resolved
pkg/deviceshifu/deviceshifulwm2m/deviceshifulwm2m.go Outdated Show resolved Hide resolved
pkg/deviceshifu/deviceshifulwm2m/deviceshifulwm2m.go Outdated Show resolved Hide resolved
pkg/deviceshifu/deviceshifulwm2m/deviceshifulwm2m.go Outdated Show resolved Hide resolved
@rhoninl rhoninl requested a review from tomqin93 October 12, 2024 07:24
Copy link
Contributor

@tomqin93 tomqin93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhoninl added some comments, please take a look

Copy link
Contributor

@tomqin93 tomqin93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhoninl added some comments, please take a look

pkg/deviceshifu/deviceshifulwm2m/lwm2m/lwm2m.go Outdated Show resolved Hide resolved
pkg/deviceshifu/deviceshifulwm2m/lwm2m/lwm2m.go Outdated Show resolved Hide resolved
pkg/deviceshifu/deviceshifulwm2m/lwm2m/ciphersuite.go Outdated Show resolved Hide resolved
pkg/deviceshifu/deviceshifulwm2m/lwm2m/lwm2m.go Outdated Show resolved Hide resolved
Copy link
Contributor

@tomqin93 tomqin93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhoninl added some typo comments

@rhoninl rhoninl requested a review from tomqin93 October 15, 2024 02:29
Copy link
Contributor

@tomqin93 tomqin93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhoninl added 2 minor comments, rest looks good

Makefile Show resolved Hide resolved
Copy link
Contributor

@tomqin93 tomqin93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's create an issue to add tests

Copy link
Contributor

@kris21he kris21he left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomqin93 tomqin93 merged commit 5105693 into main Oct 15, 2024
13 of 15 checks passed
@tomqin93 tomqin93 deleted the deviceshifu_lwM2M branch October 15, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants