[issue #1115] check if <updateIntervalSec> in Gateway is a positive i… #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ositive integer.
rhoninl
reviewed
Mar 3, 2025
pkg/gateway/lwm2m/gatewaylwm2m.go
Outdated
Comment on lines
51
to
57
| if edgedevice.Spec.GatewaySettings.LwM2MSetting == nil { | ||
| return nil, fmt.Errorf("LwM2MSetting not found in EdgeDevice spec.GatewaySettings") | ||
| } | ||
| if edgedevice.Spec.GatewaySettings.LwM2MSetting.UpdateIntervalSec <= 0 { | ||
| return nil, fmt.Errorf("LwM2MSetting UpdateIntervalSec must be greater than 0, current value: %d", edgedevice.Spec.GatewaySettings.LwM2MSetting.UpdateIntervalSec) | ||
| } | ||
|
|
There was a problem hiding this comment.
can we use kubebuilder to validate the value?
There was a problem hiding this comment.
It has been modified.
…ositive integer.
There was a problem hiding this comment.
PR Overview
This PR ensures that the updateIntervalSec field is validated as a positive integer in Gateway configurations.
- Added a kubebuilder validation marker for a minimum value of 1 in the Go type definition.
- Updated the CRD YAML configuration to enforce a minimum value of 1 for updateIntervalSec.
Reviewed Changes
| File | Description |
|---|---|
| pkg/k8s/api/v1alpha1/edgedevice_types.go | Added kubebuilder validation for updateIntervalSec to require a minimum of 1. |
| pkg/k8s/crd/config/edgedevice/bases/shifu.edgenesis.io_edgedevices.yaml | Updated the CRD spec to include a minimum of 1 for updateIntervalSec for added consistency. |
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nteger.
What this PR does / why we need it:
fix #1115
Will this PR make the community happier?
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #How is this PR tested
Special notes for your reviewer:
Release note: