Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user views and models #13

Merged
merged 2 commits into from
Jan 14, 2024
Merged

Conversation

EdinsonRequena
Copy link
Owner

This commit adds new views and models for the users app. It includes the following changes:

  • Added __init__.py files for the views and models directories.
  • Created the CustomUser model in users/models/custom_user_models.py.
  • Added constants in users/constants.py.
  • Updated the imports in users/urls.py to use the new views.
  • Added test files for the LoginUserAPIView and UserProfileAPIView views.

This commit adds new views and models for the users app. It includes the following changes:
- Added `__init__.py` files for the `views` and `models` directories.
- Created the `CustomUser` model in `users/models/custom_user_models.py`.
- Added constants in `users/constants.py`.
- Updated the imports in `users/urls.py` to use the new views.
- Added test files for the `LoginUserAPIView` and `UserProfileAPIView` views.
@pep8speaks
Copy link

pep8speaks commented Jan 14, 2024

Hello @EdinsonRequena! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 17:80: E501 line too long (87 > 79 characters)

Line 61:80: E501 line too long (84 > 79 characters)

Line 11:80: E501 line too long (94 > 79 characters)
Line 20:80: E501 line too long (95 > 79 characters)
Line 24:80: E501 line too long (86 > 79 characters)
Line 27:80: E501 line too long (84 > 79 characters)
Line 28:80: E501 line too long (91 > 79 characters)
Line 39:80: E501 line too long (98 > 79 characters)
Line 52:80: E501 line too long (99 > 79 characters)

Line 26:80: E501 line too long (100 > 79 characters)
Line 45:80: E501 line too long (96 > 79 characters)
Line 56:80: E501 line too long (93 > 79 characters)
Line 71:80: E501 line too long (82 > 79 characters)
Line 74:80: E501 line too long (96 > 79 characters)
Line 76:80: E501 line too long (103 > 79 characters)
Line 85:80: E501 line too long (90 > 79 characters)
Line 87:80: E501 line too long (82 > 79 characters)
Line 98:80: E501 line too long (96 > 79 characters)

Line 19:80: E501 line too long (96 > 79 characters)

Comment last updated at 2024-01-14 11:24:47 UTC

Copy link

sonarcloud bot commented Jan 14, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
87.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@EdinsonRequena EdinsonRequena merged commit 685e6bc into develop Jan 14, 2024
2 checks passed
@EdinsonRequena EdinsonRequena deleted the refactor/update-users-views branch January 14, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants