Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: change container back to einsteintoolkit #44

Merged
merged 2 commits into from
Aug 13, 2024
Merged

CI: change container back to einsteintoolkit #44

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
174121e
CI: change container back to einsteintoolkit
lwJi Aug 13, 2024
b88fdde
CI: update ci.yml
lwJi Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 7 additions & 17 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ name: CI
# Control when the workflow will run
on:
push:
pull_request:
# `pull_request` is disabled because we already build for all pushes
# pull_request:
# Allow running this workflow manually from the Actions tab
workflow_dispatch:

Expand All @@ -22,6 +23,7 @@ jobs:
mode: [debug, optimize]
exclude:
- {accelerator: rocm, real-precision: real32}
- {accelerator: rocm, mode: debug} # uses too much memory?
- {real-precision: real32, mode: optimize}
env:
ACCELERATOR: ${{matrix.accelerator}}
Expand All @@ -30,19 +32,13 @@ jobs:

# The type of runner that the job will run on
runs-on: ubuntu-latest
container: lwji/carpetx:${{matrix.accelerator}}-${{matrix.real-precision}}
container: einsteintoolkit/carpetx:${{matrix.accelerator}}-${{matrix.real-precision}}

# Steps represent a sequence of tasks that will be executed as part of the job
steps:
# Check out the repository under $GITHUB_WORKSPACE, so our job can access it
- uses: actions/checkout@v4

# # Check out the documentation and test results
# - uses: actions/checkout@v3
# with:
# ref: gh-pages
# path: gh-pages

- name: Log the triggering commit
run: echo ${{github.event.client_payload.trigger}}

Expand All @@ -51,14 +47,8 @@ jobs:

- name: Build Cactus
run: /bin/bash $GITHUB_WORKSPACE/scripts/build.sh

- name: Test Cactus
# We cannot run with cuda nor with rocm. Debug builds run too slowly.
if: ${{matrix.accelerator == 'cpu' && matrix.mode == 'optimize'}}
# We cannot run on accelerators. Single precision output is not accurate enough. Debug builds run too slowly.
if: ${{matrix.accelerator == 'cpu' && matrix.real-precision == 'real64' && matrix.mode == 'optimize'}}
run: /bin/bash $GITHUB_WORKSPACE/scripts/test.sh

# Set exit code based on test status
- name: Set exit code
# Only look at the test results for `carpetx-cpu-real64` runs
if: ${{matrix.accelerator == 'cpu' && matrix.real-precision == 'real64' && matrix.mode == 'optimize' && env.TESTS_FAILED == 'True'}}
run: exit 1