Skip to content
This repository has been archived by the owner on Feb 27, 2022. It is now read-only.

Uses okHttp Parallel/Chunk Downloader as described here: #52

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

YiannisOSC
Copy link

Uses okHttp Parallel/Chunk Downloader as described here:
tonyofrancis/Fetch#136

Increased the download speed of large files in Android.
Has only been only tested for a simple RNBackgroundDownloader.download not parallel downloads neither task recoveries.

@ptelad
Copy link
Contributor

ptelad commented Oct 22, 2019

Good idea.
It'll need to be tested with multiple download (using the test app) before merging, just to be sure it still works OK.

@YiannisOSC
Copy link
Author

I tested with the test app on my android device (motorola one android 9) and looks fine.
I successfully started multiple downloads , paused and retrieved after closing and reopening the app. The download speed depends on wifi and many factors so it might need more tests to see the impact of that change but it seems to work fine

# Conflicts:
#	android/build.gradle
#	android/src/main/java/com/eko/RNBackgroundDownloaderModule.java
@ptelad
Copy link
Contributor

ptelad commented May 7, 2020

Great!
One last question before I merge, is there a reason you removed the line .setNamespace("RNBackgroundDownloader")?

@kesha-antonov
Copy link

@ptelad hi! any news on this?
Also on other PRs. They work fine

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants