-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cluster based estimator #275
Conversation
f2e2026
to
11d26db
Compare
beluga/test/beluga/estimation/test_cluster_based_estimation.cpp
Outdated
Show resolved
Hide resolved
11d26db
to
0370372
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glpuga This is amazing! I didn't get to review the contents of cse_detail
in much detail yet (no pun intended), but overall everything looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @glpuga ! I'd love to see if this effectively fixes our last pending issues.
beluga/test/beluga/estimation/test_cluster_based_estimation.cpp
Outdated
Show resolved
Hide resolved
beluga/test/beluga/estimation/test_cluster_based_estimation.cpp
Outdated
Show resolved
Hide resolved
e12e376
to
19dee8f
Compare
5b1f1a1
to
313a6ec
Compare
8b5ed0f
to
255ee46
Compare
Signed-off-by: Nahuel Espinosa <[email protected]>
255ee46
to
0dae2a5
Compare
Signed-off-by: Nahuel Espinosa <[email protected]>
5af79ad
to
5878aa2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another pass! Nice work.
Signed-off-by: Nahuel Espinosa <[email protected]>
Signed-off-by: Nahuel Espinosa <[email protected]>
Signed-off-by: Nahuel Espinosa <[email protected]>
c5090df
to
8d62ed1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Niceee
Signed-off-by: Nahuel Espinosa <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go go go!
Proposed changes
Addresses #258 and #172.
Add new cluster based estimator.
Type of change
Checklist