Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cluster based estimator #275

Merged
merged 6 commits into from
Jul 15, 2024
Merged

Conversation

glpuga
Copy link
Collaborator

@glpuga glpuga commented Dec 27, 2023

Proposed changes

Addresses #258 and #172.

Add new cluster based estimator.

  • Splits the space in a grid and determines the accumulated weight in each cell.
  • Starting from the weight peaks, it groups cells into clusters of ever decreasing weight. It creates as many clusters as needed to cover all the particle occupied space.
  • Estimates mean and covariance for each.
  • Returns the mean and covariance of the cluster with the highest cumulative weight.

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

Checklist

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

@glpuga glpuga self-assigned this Dec 27, 2023
@glpuga glpuga force-pushed the glpuga/cluster_based_estimation branch 11 times, most recently from f2e2026 to 11d26db Compare December 27, 2023 21:41
@glpuga glpuga marked this pull request as ready for review December 27, 2023 21:43
@glpuga glpuga force-pushed the glpuga/cluster_based_estimation branch from 11d26db to 0370372 Compare December 28, 2023 17:36
Copy link
Member

@nahueespinosa nahueespinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glpuga This is amazing! I didn't get to review the contents of cse_detail in much detail yet (no pun intended), but overall everything looks good.

Copy link
Collaborator

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @glpuga ! I'd love to see if this effectively fixes our last pending issues.

@glpuga glpuga force-pushed the glpuga/cluster_based_estimation branch 7 times, most recently from e12e376 to 19dee8f Compare February 25, 2024 01:31
@nahueespinosa nahueespinosa force-pushed the glpuga/cluster_based_estimation branch 5 times, most recently from 5b1f1a1 to 313a6ec Compare June 26, 2024 02:37
@nahueespinosa nahueespinosa force-pushed the glpuga/cluster_based_estimation branch 2 times, most recently from 8b5ed0f to 255ee46 Compare July 6, 2024 19:01
@nahueespinosa nahueespinosa changed the title Add new cluster based estimator Add cluster based estimator Jul 6, 2024
Signed-off-by: Nahuel Espinosa <[email protected]>
@nahueespinosa nahueespinosa force-pushed the glpuga/cluster_based_estimation branch from 255ee46 to 0dae2a5 Compare July 6, 2024 19:02
@nahueespinosa nahueespinosa force-pushed the glpuga/cluster_based_estimation branch from 5af79ad to 5878aa2 Compare July 9, 2024 16:41
Copy link
Collaborator

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another pass! Nice work.

Signed-off-by: Nahuel Espinosa <[email protected]>
Signed-off-by: Nahuel Espinosa <[email protected]>
@nahueespinosa nahueespinosa force-pushed the glpuga/cluster_based_estimation branch from c5090df to 8d62ed1 Compare July 9, 2024 22:30
@nahueespinosa nahueespinosa requested a review from hidmic July 9, 2024 23:12
Copy link
Collaborator

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niceee

Signed-off-by: Nahuel Espinosa <[email protected]>
@nahueespinosa nahueespinosa requested a review from hidmic July 12, 2024 15:15
Copy link
Collaborator

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go go go!

@nahueespinosa nahueespinosa merged commit e8ca261 into main Jul 15, 2024
9 of 10 checks passed
@nahueespinosa nahueespinosa deleted the glpuga/cluster_based_estimation branch July 15, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp Related to C++ code enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants