Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for tuple vector assignment and conversion #285

Merged
merged 3 commits into from
Jan 10, 2024
Merged

Add support for tuple vector assignment and conversion #285

merged 3 commits into from
Jan 10, 2024

Conversation

nahueespinosa
Copy link
Member

Proposed changes

Related to #279.

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

Checklist

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

@nahueespinosa nahueespinosa added enhancement New feature or request cpp Related to C++ code labels Jan 9, 2024
@nahueespinosa nahueespinosa self-assigned this Jan 9, 2024
@nahueespinosa nahueespinosa requested review from hidmic and glpuga January 9, 2024 21:37
@nahueespinosa nahueespinosa force-pushed the nahuel/tuple-vector-conversion branch from 954922c to 637ec6b Compare January 9, 2024 22:03
hidmic
hidmic approved these changes Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simply flawless 💪

@nahueespinosa nahueespinosa force-pushed the nahuel/tuple-vector-conversion branch from 854f94b to a7ea0c1 Compare January 10, 2024 03:16
@nahueespinosa
Fix type alias
1616bb6 
Signed-off-by: Nahuel Espinosa <[email protected]>
@nahueespinosa nahueespinosa merged commit aeeabf9 into main Jan 10, 2024
8 checks passed
@nahueespinosa nahueespinosa deleted the nahuel/tuple-vector-conversion branch January 10, 2024 12:29
nahueespinosa added a commit that referenced this pull request Jan 10, 2024
@nahueespinosa
Add support for tuple vector assignment and conversion (#285)
8b5c06e 
Related to #279.

Signed-off-by: Nahuel Espinosa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic approved these changes

@glpuga glpuga Awaiting requested review from glpuga

Assignees

@nahueespinosa nahueespinosa

Labels
cpp Related to C++ code enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nahueespinosa @hidmic