2D NDT-MCL ROS 2 node #345
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alon Druck <[email protected]>
Signed-off-by: Alon Druck <[email protected]>
note: The comments are serving as a guide for the upcoming changes Signed-off-by: Alon Druck <[email protected]>
Signed-off-by: Alon Druck <[email protected]>
Signed-off-by: Alon Druck <[email protected]>
Signed-off-by: Alon Druck <[email protected]>
note: in the future change it to the amcl_core Signed-off-by: Alon Druck <[email protected]>
|
Closing in favor of #347 |
7 tasks
hidmic
added a commit
that referenced
this pull request
May 19, 2024
### Proposed changes Follow-up to #345. This spurious include was left behind. #### Type of change - [x] 🐛 Bugfix (change which fixes an issue) - [ ] 🚀 Feature (change which adds functionality) - [ ] 📚 Documentation (change which fixes or extends documentation) ### Checklist - [x] Lint and unit tests (if any) pass locally with my changes - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have added necessary documentation (if appropriate) - [x] All commits have been signed for [DCO](https://developercertificate.org/) Signed-off-by: Michel Hidalgo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Addresses #312
Implement 2D NDT-MCL ROS 2 node
Type of change
Checklist
Put an
xin the boxes that apply. This is simply a reminder of what we will require before merging your code.