Use gcovr to enforce code coverage everywhere
#437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hidmic
commented
Sep 30, 2024
7 tasks
|
Noetic is below 95%. Rolling is just failing everywhere. |
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
hidmic
force-pushed
the
hidmic/check-code-coverage
branch
from
9eca23e to
4dfc931
Compare
Signed-off-by: Michel Hidalgo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Closes #434 (kinda). This patch introduces
gcovrfor code coverage enforcement for all distributions and workflows.codecovremains in use for Humble jobs triggered by local workflows.Type of change
Checklist
Additional comments
The choice of
gcovrin addition tolcovhas to do with feature support. Only the newest versions oflcov, available starting Noble, have the "fail under X coverage" feature. Alas,colcon'slcovintegration is all broken in Noble -.-.