Update detect_package_manager
to look for new Bun lockfile
#530
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📖
Update the
detect_package_manager
method so that it looks for both Bun lockfile formats. Without this change, Bun setups that use the new lockfile format could fail to build, since Vite Ruby would incorrectly think thatnpm
was the desired package manager.Background 📜
Bun is in the process of switching from the binary
bun.lockb
file to a new, text-basedbun.lock
file.As of Bun 1.2, the new text-based lockfile is the default. We need to update the
detect_package_manager
to look for both lockfile formats, but we should be able to eventually retire the binary lockfile format.More info: https://bun.sh/docs/install/lockfile#text-based-lockfile
The Fix 🔨
By looking for the new lockfile format (as well as the old one), the
detect_package_manager
method will correctly state that Bun is the desired package manager for Bun setups that use the new lockfile format.Screenshots 📷
Here are excerpts of a failing deploy log:
This is the first deploy we've attempted since merging a PR that upgraded Bun to use the new lockfile format.