Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Transifex client used in Travis. #804

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

metc
Copy link
Member

@metc metc commented Oct 27, 2017

Simplify a bit the logic to install the Transifex client and push the generated language file.

  • Use API token set in Travis UI.
  • Install the latest transifex Python client and do not compile from source any more. Do this only when needed and not for every build. Should speed-up the build time a bit.

Simplify a bit the logic to install the Transifex client and push the generated language file.
Use API token set in Travis UI.
Install the latest transifex Python client and do not compile from source any more. Do this only when needed and not for every build. Should speed-up the build time a bit.
@metc metc requested a review from cm0x4D October 27, 2017 21:28
@@ -4,21 +4,24 @@
#
# Generate and push the source language file to Transifex.
# This script is called after every successful build on Travis CI.
# It relies on $TRANSIFEX_PASSWORD being set in .travis.yml
# The Transifex client must be installed.

if [ "$TRAVIS_REPO_SLUG" == "Electrical-Age/ElectricalAge" ] && [ "$TRAVIS_PULL_REQUEST" == "false" ] && [ "$TRAVIS_BRANCH" == "develop" ]
Copy link
Member Author

@metc metc Oct 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cm0x4D Just realized this one will be hard to sanity check and get green before merging since the script this is not executed for PR :)

@Baughn
Copy link
Contributor

Baughn commented Feb 3, 2019

Is this PR still up to date? If so, let's try it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants