Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ba/feature/vertical search #320

Merged
merged 32 commits into from
Jan 24, 2024
Merged

Ba/feature/vertical search #320

merged 32 commits into from
Jan 24, 2024

Conversation

bradleyandrick
Copy link
Contributor

Related Issue(s):

  • NA

Proposed Changes:

  1. Move to vertical filter and search instead of top filters.
  2. Remove mention of 'Advanced' search and integrate AOI draw/upload into regular filters list.
  3. Move cart component to top nav bar.
  4. Reduce height of top nav bar.
  5. Results info panel relocated to be sticky to top left of map frame.

BONUSES:

  1. NEW FEATURE: Shortcut added for running search when SPACE key press.
  2. Remove search re-run on view mode toggle.
  3. Remove Auto Search feature completely.
  4. Remove publish button and modal.
  5. Bug fix for tooltip not closing on mouseout for gridcode aggregation hover.

To Test:

**Tests pass 🍏 **

Search Flow - No regressions

  • load app
  • confirm layout renders with vertical filters/search now on left side of screen
  • perform search
  • tests filters and confirm no regressions in expected functionality

Space Bar Search

  • load app
  • hit space bar
  • confirm search runs
  • zoom and pan while occasionally hitting space bar
  • confirm search keeps running when hit
  • confirm debounce works if hit too often

Bug Fix For Tooltip

  • load app
  • search for a collection that shows gridcode aggreations
  • hover cursor quickly over footprints
  • confirm tooltips close on hover
  • confirm no orphaned tooltips remain after mouseout

No search on View Mode Toggle

  • load app
  • toggle from scene mode to mosaic
  • confirm search does not run
  • click search button
  • confirm search does run

PR Checklist:

  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.

Copy link

@philvarner philvarner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thoroughly tested, looks good

@bradleyandrick bradleyandrick merged commit 19832db into main Jan 24, 2024
3 checks passed
@philvarner philvarner deleted the ba/feature/vertical-search branch January 24, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants