Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ba/feature/relocate popup result #330

Merged
merged 43 commits into from
Feb 15, 2024
Merged

Conversation

bradleyandrick
Copy link
Contributor

Related Issue(s):

  • NA

Proposed Changes:

  1. Move popup results component location to reuse the vertical search LeftContent section of the app
  2. Refactor popup results to remove unnecessary functionality after moving
  3. Add tabbed header in LeftContent layout to handle switching between filtering/search and viewing result details

BONUS 1: adds config option for STAC_LINK_ENABLED to render link out to item in STAC API

BONUS 2: adds config option for SHOW_ITEM_AUTO_ZOOM to render switch that lets user toggle behavior of map center/zooming automatically on selected scene

BONUS 3: refactor loading overlay to specify when it's imagery loading instead of the same generic 'results are loading' spinner graphic that covers whole map when new search or app is loading

BONUS 4: bug fix - when selecting multiple grids from the grid-code aggregation footprint results, only a single grid-code was being shown in popup results when more grid-codes were showing as selected on map

BONUS 5: bug fix - refactor keyboard shortcut for running search again. previously this was just using the space bar keydown BUT this causes error when used in regular patterns - like typing in the geocoder. changed to be ctrl+spacebar

To Test:

Testing steps provided offline in project channel, contact PR author for details

PR Checklist:

  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.

@philvarner
Copy link

this seems a little off

image

not enough leading, and I can't tell the autozoom is a slider

@philvarner
Copy link

"STAC Item:click to view item in STAC API" seems a bit too verbose -- maybe just hyperlink the Title value?

@bradleyandrick
Copy link
Contributor Author

comments address and discussed offline for: filter spacing & style & stac link

@bradleyandrick bradleyandrick merged commit d92ea81 into main Feb 15, 2024
4 checks passed
@bradleyandrick bradleyandrick deleted the ba/feature/relocate-popup-result branch August 2, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants