-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ba/feature/relocate popup result #330
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"STAC Item:click to view item in STAC API" seems a bit too verbose -- maybe just hyperlink the Title value? |
comments address and discussed offline for: filter spacing & style & stac link |
philvarner
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Proposed Changes:
BONUS 1: adds config option for
STAC_LINK_ENABLED
to render link out to item in STAC APIBONUS 2: adds config option for
SHOW_ITEM_AUTO_ZOOM
to render switch that lets user toggle behavior of map center/zooming automatically on selected sceneBONUS 3: refactor loading overlay to specify when it's imagery loading instead of the same generic 'results are loading' spinner graphic that covers whole map when new search or app is loading
BONUS 4: bug fix - when selecting multiple grids from the grid-code aggregation footprint results, only a single grid-code was being shown in popup results when more grid-codes were showing as selected on map
BONUS 5: bug fix - refactor keyboard shortcut for running search again. previously this was just using the space bar keydown BUT this causes error when used in regular patterns - like typing in the geocoder. changed to be
ctrl+spacebar
To Test:
PR Checklist: