Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package extras for watsonx support #2426

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

kiersten-stokes
Copy link
Contributor

#2397 added support for watsonx LLM inference. This PR updates the pyproject.toml to include an ibm_watsonx_ai package extra

NIT: it also removes an unused function, but happy to remove that commit in case there is context that I'm missing here or in the spirit of keeping this PR atomic

@CLAassistant
Copy link

CLAassistant commented Oct 24, 2024

CLA assistant check
All committers have signed the CLA.

@kiersten-stokes
Copy link
Contributor Author

@Medokins @yoavkatz let me know if you have any thoughts

@kiersten-stokes
Copy link
Contributor Author

Hmm I see now why this may not have been included - the ibm-watsonx-ai package doesn't support python 3.8. I suppose in that case this is more of an open question to the maintainers about whether there is a precedent for this scenario and what the desired course of action is (if anything)

@baberabb
Copy link
Contributor

Thanks for the PR! the test is failing to the recent transformers update. :)

@baberabb baberabb merged commit 7882043 into EleutherAI:main Oct 25, 2024
4 of 8 checks passed
@ruivieira
Copy link

Hi everyone,

I noticed there's no version range for the ibm-watsonx-ai dependency. Is it correct to assume that the minimum safe version would be the latest, at the time of writing (1.1.16)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants