Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update picostdlib examples #35

Closed
wants to merge 2 commits into from
Closed

Conversation

casey-SK
Copy link
Contributor

@casey-SK casey-SK commented Jan 7, 2022

Purpose:

My intent here is to create a better structure for the examples included in the picostdlib. I have arranged the examples as follows:

  • Each example should be numbered, low numbers representing easier / common concepts and higher numbers representing difficult / less common concepts
  • Each example should cover some basic functionality and try to limit itself to that functionality and concepts that have been covered already in the lower numbered examples.
  • The examples should run on the original Pico, and require little in terms of external components.
  • The examples should include a title, description, and be well commented.

Note that so far, I have only completed 6 examples in the manor described, hope to finish the rest soon. I have tested them all to ensure that they run correctly.

I deleted the redundant examples that covered the same concepts, and left the examples the I have not yet look at. I also changed the import statements for the remaining hello_ programs.

I am curious to know how many examples you guys think we should have? did you have a limit in mind?

@beef331
Copy link
Collaborator

beef331 commented Jan 7, 2022

I am curious to know how many examples you guys think we should have? did you have a limit in mind?

As many as you want, ideally these work as tests that the API atleast compiles and works, but the down side is hard to test.

@casey-SK
Copy link
Contributor Author

casey-SK commented Jan 7, 2022

haha, I haven't closed (#3) yet. I would like to at the very least test that they build without error. I watched a video about debugging, and it takes a lot of steps haha

@beef331
Copy link
Collaborator

beef331 commented Jan 7, 2022

Yea properly testing this stuff works is very much in the category of having a bunch of breakout boards that could be dropped on to test X module/feature.

@beef331
Copy link
Collaborator

beef331 commented Jan 7, 2022

For one the example PR should be separate to the piconim link changes. Though secondly i dont know how i feel with the solution for link libraries. Iterating every C file searching for a string seems ugh. Need to think about it more.

@casey-SK
Copy link
Contributor Author

casey-SK commented Jan 8, 2022

dang, sorry for being an amateur with git. I am going to close this PR and try again.

@casey-SK casey-SK closed this Jan 8, 2022
@beef331
Copy link
Collaborator

beef331 commented Jan 8, 2022

All you need to do is git rebase -i HEAD~2 and drop the last commit(after making another branch), then push over this, then in the other branch drop everything but the latest commit doing git rebase -i #commitBeforeWorkAdded then dropping all between then and now.

@casey-SK
Copy link
Contributor Author

casey-SK commented Jan 8, 2022

Oh okay, once I try that, I will reopen this. Sorry for testing your patience like this haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants