-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oscilloscope control automation #252
Open
nitin710
wants to merge
17
commits into
master
Choose a base branch
from
feat-OscilloscopeControlAutomation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pulling latest master into this branch
…ternal class pointer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Requirements
Issues Referenced
Requested from reviewer
Documentation update
None
Notes for Reviewer
Additional Documents
Using this feature
Requirements
sectionfeat-OscilloscopeControlAutomation
.ofxEmotiBit/tests/EmotiBitOscilloscopeAutomation
../testing_seq.sh --emotibit-id <YOUR_EMOTIBIT_ID>
./testing_seq.sh --emotibit-id MD-V5-0000005
Testing
testing_sq.sh
EC.sh
ED.sh
RB.sh
RE.sh
Results
Feature Tests
ToDo
clearOscilloscope()
is not called when connecting/disconnecting from EmotiBit(s). In my testing this does not cause any issues if all EmotiBits are MDs. But might cause GUI errors if switching between EMO and MD. We need more testing. Additionally,clearOscilloscope()
is an ofApp function, that should be called using ofEvent or other mechanism when a WiFi_host command is being executed.Checklist to allow merge
master
ofxEmotiBitVersion.h