Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect during initialization whether the IP is from mainland China. If so, prompt the user to choose whether to use a mirror to fetch the BDS version. #99

Closed
wants to merge 1 commit into from

Conversation

xjh2009
Copy link

@xjh2009 xjh2009 commented Dec 5, 2024

During initialization, access to raw.githubusercontent.com is required to fetch the BDS. However, this domain is inaccessible from mainland China. Therefore, if the IP is detected to be from mainland China, it is recommended to use ghp.ci as a mirror.

@virgil698
Copy link

哥们你认真的吗?

Dude, are you serious?

中国大陆地区直接用 cn.minecraft.wiki 手动安装BDS服务端就能解决的问题

The problem that can be solved in Chinese Mainland by manually installing the BDS server directly with cn.minecraft.wiki

所以,整个是否中国大陆地区使用镜像源,个人觉得没啥必要

Therefore, I don't think it is necessary to use image source in Chinese Mainland

如果你要这么做,请先与 EndStone 中国大陆地区开发者进行联系,确认这么做有必要后再提交也不迟

If you want to do this, please contact the developers in Chinese Mainland of EndStone first to confirm that it is necessary before submitting it

@smartcmd
Copy link
Contributor

smartcmd commented Dec 5, 2024

I don't agree with this pr

@xjh2009
Copy link
Author

xjh2009 commented Dec 5, 2024

哥们你认真的吗?

Dude, are you serious?

中国大陆地区直接用 cn.minecraft.wiki 手动安装BDS服务端就能解决的问题

The problem that can be solved in Chinese Mainland by manually installing the BDS server directly with cn.minecraft.wiki

所以,整个是否中国大陆地区使用镜像源,个人觉得没啥必要

Therefore, I don't think it is necessary to use image source in Chinese Mainland

如果你要这么做,请先与 EndStone 中国大陆地区开发者进行联系,确认这么做有必要后再提交也不迟

If you want to do this, please contact the developers in Chinese Mainland of EndStone first to confirm that it is necessary before submitting it

@xjh2009 xjh2009 closed this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants