Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: applies native-proto buildifier fixes #11

Merged
merged 1 commit into from
Dec 4, 2024
Merged

chore: applies native-proto buildifier fixes #11

merged 1 commit into from
Dec 4, 2024

Conversation

iamricard
Copy link
Contributor

@iamricard iamricard requested review from saraadams and Yannic December 4, 2024 11:05
saraadams
saraadams previously approved these changes Dec 4, 2024
View reviewed changes
@saraadams saraadams dismissed their stale review December 4, 2024 11:31

second thoughts

saraadams
saraadams reviewed Dec 4, 2024
View reviewed changes
Copy link

@saraadams saraadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the source of truth is in Engflow/engflow and changes are copied over from there. @Yannic to give input.

Yannic
Yannic approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@Yannic Yannic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow-up internally to also update SoT or this will get reverted the next time we export

@Yannic Yannic merged commit 6594022 into main Dec 4, 2024
2 checks passed
@Yannic Yannic deleted the buildifier-fixes branch December 4, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saraadams saraadams saraadams left review comments

@Yannic Yannic Yannic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iamricard @saraadams @Yannic