Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added go support and hello world example #43

Merged
merged 7 commits into from
Nov 8, 2022
Merged

Conversation

anfelbar
Copy link
Collaborator

@anfelbar anfelbar commented Nov 7, 2022

About

Adding Go support and hello world example.
Run with bazel run //go

Progress #36

@TheGrizzlyDev
Copy link
Contributor

Can we make the example less trivial? Maybe add some dependencies and more than just a file?

@anfelbar
Copy link
Collaborator Author

anfelbar commented Nov 8, 2022

The first commits try to add support for the language. Maybe a test. This addresses this #36. I have no experience with go, scala, swift, so I am just adding a hello world example and continue from there as wee need to do some more work this repository #40.
Now, if you have a go example I can just copy and paste, then I change this PR, no problem whatsoever. Any example suggestion?

Copy link
Contributor

@jayconrod jayconrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Fine to start with a simple example, and we can expand it later. As an idea, I like small gRPC servers as Bazel examples, since it demonstrates code generation and cross-language projects. Also protoc is not a small tool, and if we can compile it very quickly on remote execution, that's a nice demo.

WORKSPACE Outdated Show resolved Hide resolved
WORKSPACE Outdated Show resolved Hide resolved
@jayconrod
Copy link
Contributor

Probably out of scope for this PR but FYI: I think this will only work for remote execution if the execution platform is the same as the host platform. Our CI in this repo doesn't appear to cover remote execution.

@anfelbar
Copy link
Collaborator Author

anfelbar commented Nov 8, 2022

Probably out of scope for this PR but FYI: I think this will only work for remote execution if the execution platform is the same as the host platform. Our CI in this repo doesn't appear to cover remote execution.

I think that's okay. These examples will be useful for running against a cluster with remote execution capabilities. I just ran it in our canary and it works. It is slow though.

@anfelbar anfelbar merged commit 15f621e into main Nov 8, 2022
@anfelbar anfelbar deleted the andres-go-example branch November 8, 2022 19:41
@anfelbar anfelbar mentioned this pull request Nov 22, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants