-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added go support and hello world example #43
Conversation
Can we make the example less trivial? Maybe add some dependencies and more than just a file? |
The first commits try to add support for the language. Maybe a test. This addresses this #36. I have no experience with go, scala, swift, so I am just adding a hello world example and continue from there as wee need to do some more work this repository #40. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Fine to start with a simple example, and we can expand it later. As an idea, I like small gRPC servers as Bazel examples, since it demonstrates code generation and cross-language projects. Also protoc is not a small tool, and if we can compile it very quickly on remote execution, that's a nice demo.
Probably out of scope for this PR but FYI: I think this will only work for remote execution if the execution platform is the same as the host platform. Our CI in this repo doesn't appear to cover remote execution. |
Co-authored-by: Jay Conrod <[email protected]>
I think that's okay. These examples will be useful for running against a cluster with remote execution capabilities. I just ran it in our canary and it works. It is slow though. |
About
Adding Go support and hello world example.
Run with
bazel run //go
Progress #36