Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new script to check Compara FTP dumps #883

Open
wants to merge 2 commits into
base: release/114
Choose a base branch
from

Conversation

twalsh-ebi
Copy link
Contributor

@twalsh-ebi twalsh-ebi commented Feb 4, 2025

Description

This PR adds script check_compara_ftp_files.pl, which is much like verify_ftp_dumps.pl, except that it checks for specific expected files and directories in all but a handful of cases. In the small minority of cases where an exact file name is not used, a highly specific regex is used instead.

The sets of expected file names and patterns are obtained from the relevant Compara database.The expected file sets are then checked against the observed files in the Compara FTP dump directory. If there are any issues, these are reported in an output TSV file.

Testing

This script has been tested on e113 Compara FTP dump files.


For code reviewers: code review SOP

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.67%. Comparing base (66d1e7c) to head (279d9fd).

Additional details and impacted files
@@               Coverage Diff               @@
##           release/114     #883      +/-   ##
===============================================
- Coverage        60.67%   60.67%   -0.01%     
===============================================
  Files              212      212              
  Lines            23026    23026              
  Branches          3631     3631              
===============================================
- Hits             13972    13971       -1     
  Misses            7835     7835              
- Partials          1219     1220       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant