mdct-2555 fix submitAndUncertify e2e #139411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
britt-mo
requested review from
BearHanded,
braxex and
cassandradanger
as code owners
|
Code Climate has analyzed commit 99df1f2 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 55.6% (0.0% change). View more on Code Climate. |
BearHanded
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
submitAndUncertifytest was created as part of an attempt to have a good smoke test in each env for user interaction. It can get in a state where all reports have been submitted, and there is nothing for a state user to enter. This change adds a step for an admin to login and uncertify a report if there is at least one report that has been submitted. This way the test should never get to the state user logging in and being unable to edit a report.Related ticket(s)
MDCT-2555
How to test
Should pass on deploy :)
Important updates
Author checklist
convert to a different template: test → val | val → prod