Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDCT-2526] Update Filter on home page to use the year from state #139442

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

BearHanded
Copy link
Contributor

Description

The filter dropdown was hardcoded per year. Tied it into the state's currentYear flag to at least centralize those.

Related ticket(s)

MDCT-2526


How to test

The dropdown for Year filter should list 2023

Important updates


Author checklist

  • I have performed a self-review of my code
  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary

convert to a different template: test → val | val → prod

@codeclimate
Copy link

codeclimate bot commented Aug 29, 2023

Code Climate has analyzed commit 3c2473c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 55.6% (0.0% change).

View more on Code Climate.

@BearHanded BearHanded merged commit 71225b4 into main Aug 29, 2023
14 checks passed
@BearHanded BearHanded deleted the mdct-2526-filter-year branch August 29, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants