-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable field 2 in Basic State Information #139460
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial refactor. There are other places that use programType differently and will need to be remedied. This is just a start.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check it out!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked at this pretty thoroughly, and this looks solid, but I haven't had a chance to run it locally. Will update if I do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice. Especially like that you updated the shouldDisplay tests for clarity 👍
4324f90
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran this locally and tested it against rendering sections. I am seeing that the browser needs to refresh before rendering the new state for a section.
Replication steps:
- Start with the report as a "combo"
- Switch to Medicaid Expansion CHIP Only
- Navigate to 3F - The form appears when it shouldn't
- Refresh, you should now see the correct state
Code Climate has analyzed commit 9ca805e and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 61.4% (0.1% change). View more on Code Climate. |
Description
Make Question 2, Program Type, in Basic State Information editable, and update corresponding logic to make form react to this update
Three tables hold information for
programType
:state – holds a static value and thus we should seek to neither update nor read
programType
from this in the app's flowsections – no change, holds the
programType
value from the user's choice in the UIstate-status – is now updated with the value from sections, and is the sole reference for that value in the frontend because it is accessible to all user types
Related ticket(s)
MDCT-2993
How to test
show_if_state_program_type_in
in seed-section-base-2023.jsonAuthor checklist