Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev -> Val #139637

Merged
merged 9 commits into from
May 31, 2024
Merged

Dev -> Val #139637

merged 9 commits into from
May 31, 2024

Conversation

BearHanded
Copy link
Contributor

@BearHanded BearHanded commented May 22, 2024 •
edited by ntsummers1
Loading

Description

  • Update cloudfront policy headers
  • Center My Account Drop Down header on Mobile
  • Re-add setup for okta
  • Kafka Sync Unmarshall formatting numbers incorrectly (CMDCT-3673)

Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Pre-merge checklist

Review

  • Product: This work has been reviewed and approved by product owner, if necessary

@ntsummers1 ntsummers1 marked this pull request as ready for review May 30, 2024 17:41
@ntsummers1 ntsummers1 added the ready for review Ready for all the reviews! label May 30, 2024
gmrabian
gmrabian previously approved these changes May 30, 2024
View reviewed changes
@ntsummers1 ntsummers1 requested a review from gmrabian May 30, 2024 18:35
@BearHanded BearHanded merged commit 7c512c0 into val May 31, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntsummers1 ntsummers1 ntsummers1 approved these changes

@braxex braxex Awaiting requested review from braxex braxex is a code owner

@gmrabian gmrabian Awaiting requested review from gmrabian

Assignees

@BearHanded BearHanded

Labels
ready for review Ready for all the reviews!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BearHanded @ntsummers1 @gmrabian @dwhitestratiform