Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update datagrid patterns #139760

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Update datagrid patterns #139760

merged 2 commits into from
Sep 9, 2024

Conversation

gmrabian
Copy link
Contributor

@gmrabian gmrabian commented Sep 9, 2024

Description

Upgrade redux pattern and cleanup component

No user-facing change expected

  • Remove lastYearFormData prop (I didn't see this passed in anywhere and we can fetch it from state
  • Fetch lastYearFormData with useSelector
  • Remove unused, unpassed props
  • Remove mapStateToProps and connect

Related ticket(s)

CMDCT-none


How to test

https://d1ijxujmh6fr39.cloudfront.net/

  • Log in as a state user
  • Enter any report
  • Go to section 3c, part 5
  • Select "Yes" to the question 2
  • Verify the rows of integer values render
  • Verify they can be modified and save as expected

Pre-review checklist

  • [ ] I have added thorough tests, if necessary
  • [ ] I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Pre-merge checklist

Review

  • Product: This work has been reviewed and approved by product owner, if necessary

@gmrabian gmrabian marked this pull request as ready for review September 9, 2024 15:59
@gmrabian gmrabian added the ready for review Ready for all the reviews! label Sep 9, 2024
Copy link

codeclimate bot commented Sep 9, 2024

Code Climate has analyzed commit 1b3393a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 79.7% (0.0% change).

View more on Code Climate.

@gmrabian gmrabian merged commit a7d6486 into main Sep 9, 2024
18 checks passed
@gmrabian gmrabian deleted the update-datagrid branch September 9, 2024 18:21
ntsummers1 added a commit that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for all the reviews!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants