Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull previous year value for 3c fields #139761

Merged
merged 3 commits into from
Sep 9, 2024
Merged

Pull previous year value for 3c fields #139761

merged 3 commits into from
Sep 9, 2024

Conversation

gmrabian
Copy link
Contributor

@gmrabian gmrabian commented Sep 9, 2024

Description

  • Add fetch for last year's values to section 3c parts 5 and 6 when "No" is selected (such that we show subquestion -a with the totals)
    • This came from similar logic we have in DataGrid
  • Consolidate Integer component returns
  • Remove structured export (and fix dependent imports)
  • Add test!

Related ticket(s)

CMDCT-3915


How to test

CARTS dev

  • Log in as [email protected]
  • Enter AL 2022
  • Go to section 3c, part 5
  • Select “No” to the question 2
  • Verify there are values in the totals, or else enter values
  • Leave report and go to AL 2023
  • Go to section 3c, part 5
  • Select “No” to the question 2
  • Verify the values from the previous year do not show up

https://d2qk4vlw7n97j8.cloudfront.net/

  • Repeat the above steps
  • Verify the values from the previous year do show up
  • Verify you can still modify them
  • Verify any modified value takes precedence over previous year value

Pre-review checklist

  • I have added thorough tests, if necessary
  • [ ] I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Pre-merge checklist

Review

  • Product: This work has been reviewed and approved by product owner, if necessary

Copy link

codeclimate bot commented Sep 9, 2024

Code Climate has analyzed commit 65a739f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 79.9% (0.2% change).

View more on Code Climate.

@gmrabian gmrabian marked this pull request as ready for review September 9, 2024 16:32
@gmrabian gmrabian added ready for review Ready for all the reviews! product review Waiting for product review labels Sep 9, 2024
Copy link
Collaborator

@ntsummers1 ntsummers1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its b-e-a-utiful 👍

@gmrabian gmrabian merged commit e70e079 into main Sep 9, 2024
20 checks passed
@gmrabian gmrabian deleted the cmdct-3915 branch September 9, 2024 18:35
ntsummers1 added a commit that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product review Waiting for product review ready for review Ready for all the reviews!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants