Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMDCT-3976] ETL to add <11 mask to all forms #139762

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Conversation

ntsummers1
Copy link
Collaborator

@ntsummers1 ntsummers1 commented Sep 9, 2024

Description

This ETL is a follow up to the <11 PR work and expands upon the removal of certain calculations in the print view as defined in this ticket. It goes through and adds the <11 mask to the 2023 and 2022 prior forms for all states for the exact same questions and removes a few calculations in sections 3 and 5. You can see a live before and after of running this script in the deployed environment here:

Screen.Recording.2024-10-16.at.11.08.03.AM.mov

Related ticket(s)

CMDCT-3976


How to test

  • ./run local (To ensure a brand new, seeded database)
  • In a new terminal run DYNAMO_ENDPOINT=http://localhost:8000 dynamodb-admin after the local environment has fully spun up.
  • Navigate to localhost:8001 to see the local instance of dynamo.
  • Confirm that for the report AL-2022, Section 3c questions 2-4 that in the print view entering 5 still shows as 5.
  • In a new terminal, run DYNAMODB_URL="http://localhost:8000" dynamoPrefix="local" node services/database/scripts/add-less-than-eleven-mask.js
  • Reload the 2022 report
  • Navigate to Section 3c
  • See that question 2-4 in Part 5 still show your original answer of 5
  • Click the print button and then click print section at the bottom of the page
  • See that the questions answer now shows <11
  • The computed calculations will be hidden and no longer shown
  • Navigate to localhost:8001 to see the local instance of dynamo.
  • Confirm that for the report AL-2022, Section 3 that there there has been a mask added to that field.

Extra Credit

  • Logout and sign in as an admin ([email protected])
  • Open the 2022 report and navigate to Section 3c
  • See that all the fields also show <11 and computed values associated are hidden

Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Pre-merge checklist

Review

  • Product: This work has been reviewed and approved by product owner, if necessary

@ntsummers1 ntsummers1 added the draft Just a draft label Sep 9, 2024
@ntsummers1 ntsummers1 self-assigned this Sep 9, 2024
@ntsummers1 ntsummers1 changed the title ETL to add <11 mask to all forms [CMDCT-3976] ETL to add <11 mask to all forms Sep 9, 2024
@ntsummers1 ntsummers1 added question Further information is requested do not merge Do not merge this pull request and removed draft Just a draft labels Sep 9, 2024
@ntsummers1 ntsummers1 marked this pull request as ready for review September 30, 2024 16:14
@ntsummers1 ntsummers1 added ready for review Ready for all the reviews! and removed question Further information is requested labels Oct 9, 2024
@ntsummers1 ntsummers1 removed the do not merge Do not merge this pull request label Oct 16, 2024
Copy link

codeclimate bot commented Oct 16, 2024

Code Climate has analyzed commit 0acd230 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 81.1% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@gmrabian gmrabian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

herculean

@ntsummers1 ntsummers1 merged commit fc1f312 into main Oct 18, 2024
18 checks passed
@ntsummers1 ntsummers1 deleted the less-than-eleven-etl branch October 18, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for all the reviews!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants