e2e bug: add wait after submitting #139773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmrabian
changed the title
|
Code Climate has analyzed commit aa8bd74 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 80.0% (0.0% change). View more on Code Climate. |
gmrabian
requested review from
BearHanded,
braxex and
ntsummers1
as code owners
gmrabian
requested review from
jessabean,
britt-mo,
karla-vm and
bangbay-bluetiger
britt-mo
approved these changes
Sep 23, 2024
ntsummers1
added a commit
that referenced
this pull request
Sep 24, 2024
This reverts commit 9d2ff75.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our submit and uncertify tests flake out on main and val sometimes. After reviewing the videos they both get to the certify page, rapidly go through the buttons, and then re-auth as an admin. Once logged in as an admin, the expected report is still in progress. I'm wondering if the API call needs more time to get fired off. This PR simply adds a wait after hitting the button that triggers the certify call.
Failed run examples:
https://github.com/Enterprise-CMCS/macpro-mdct-carts/actions/runs/10942276801/attempts/1
https://github.com/Enterprise-CMCS/macpro-mdct-carts/actions/runs/10961006339/attempts/1
Related ticket(s)
CMDCT-4012
How to test
You can run it locally but it will pass locally even without the wait.
Merging to main/val and letting it run a few times is the best way to test.
Pre-review checklist
[ ] I have updated relevant documentation, if necessary