Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print section fix for additional user types #139800

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Print section fix for additional user types #139800

merged 3 commits into from
Oct 25, 2024

Conversation

ntsummers1
Copy link
Collaborator

@ntsummers1 ntsummers1 commented Oct 18, 2024

Description

In CMDCT-3984 we fixed it so that admins could see the print section view. I didn't realize, however, that there are additional user types that have to get the specific URL type. Therefor I've updated the list so that those users dont have the site crash when attempting to print a particular form section.


How to test

Using [email protected], [email protected], [email protected], [email protected], [email protected], and [email protected], login to carts and enter a report.
Click on the print button on the bottom and click this section
See that the page loads correctly
Back out and click on the print button on the bottom and click this form
See that the page loads correctly


Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

britt-mo
britt-mo previously approved these changes Oct 18, 2024
Copy link
Contributor

@britt-mo britt-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should have thought about this!! Working as expected now

gmrabian
gmrabian previously approved these changes Oct 18, 2024
Copy link
Contributor

@gmrabian gmrabian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good; works as expected.

I think we can be less verbose on the if statement

services/ui-src/src/components/layout/FormActions.jsx Outdated Show resolved Hide resolved
Copy link

codeclimate bot commented Oct 25, 2024

Code Climate has analyzed commit 8f19f49 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 81.1% (0.0% change).

View more on Code Climate.

@ntsummers1 ntsummers1 merged commit 04df902 into main Oct 25, 2024
18 checks passed
@ntsummers1 ntsummers1 deleted the fix-print-section branch October 25, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants