Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Amplify to v6 #139802

Merged
merged 14 commits into from
Oct 22, 2024
Merged

Upgrade Amplify to v6 #139802

merged 14 commits into from
Oct 22, 2024

Conversation

gmrabian
Copy link
Contributor

@gmrabian gmrabian commented Oct 21, 2024

Description

This change upgrades Amplify from v5 to v6 

The upgrade work was previously done in CARTS but was reverted due to an issue that has since been resolved by the maintainers.

Work already done in MCR

revived from #139616

Related ticket(s)

CMDCT-4053


How to test

Everything in the app works as expected. A short list of everything:

  • all api calls
  • auth
  • timeout
  • template file download

Pre-review checklist

  • I have added thorough tests, if necessary
  • [ ] I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Copy link

codeclimate bot commented Oct 21, 2024

Code Climate has analyzed commit c0f7f77 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 95.4% (90% is the threshold).

This pull request will bring the total coverage in the repository to 81.1% (0.0% change).

View more on Code Climate.

@gmrabian gmrabian marked this pull request as ready for review October 21, 2024 17:48
@gmrabian gmrabian added the ready for review Ready for all the reviews! label Oct 21, 2024
@gmrabian gmrabian changed the title Amplify up Upgrade Amplify to v6 Oct 21, 2024
Copy link
Contributor

@karla-vm karla-vm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Collaborator

@ntsummers1 ntsummers1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The myth, the legend. They've done it again

@gmrabian gmrabian merged commit d8a1d72 into main Oct 22, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for all the reviews!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants