Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ACS 2023 and FMAP 2025 Seed #139808

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Create ACS 2023 and FMAP 2025 Seed #139808

merged 2 commits into from
Oct 25, 2024

Conversation

ntsummers1
Copy link
Collaborator

@ntsummers1 ntsummers1 commented Oct 23, 2024

Description

Late Wednesday (Oct 23rd), A CARTS User reported that there was data not available for the Section 2 Part 2 table. Upon investigation, it looks like there is a separate seed process that needs to happen each year. Using last years tickets (See below) I followed the same steps and used this sites HI-10_ACS.xcl file to file in the relevant numbers for 2023. This was confirmed by the BO's today (Friday, Oct 25th) to be correct.

In addition, the BO's let us know that the fmap numbers are also seeded and needed to be updated. They follow a similar process and the data can be grabbed from the Federal Register for 2025. We will need to follow up for 2026's numbers soon, but those numbers are not published yet.

Related ticket(s)

CMDCT-2919
CMDCT-2949


How to test

Open the deployed instance (https://d3efzxo0yvx2p8.cloudfront.net/)
Open up a 2024 report
Navigate to Section 2, Part 2
Using the seed-acs-2023.json file, note that the table here has the exact same numbers for 2023 as the seed file.
Navigate to Section 5, Part 2 Table 3 (Federal and State Shares Table)
Using the seed-fmap.json file, note that the table here has the exact same numbers for 2025 as the seed file.

Extra credit:
Double check my numbers if you have the time. I'd owe ya big time 🤗.

seed-acs-2023 gets its numbers from this site, under the link HI-10_ACS (It'll open a file called hi10_acs.xcl. We're using the numbers from columns D-G.

seed-fmap gets its numbers from this site, using the first tables right most column (The Enhanced federal medical assistance percentages).


Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Pre-merge checklist

Review

  • Product: This work has been reviewed and approved by product owner, if necessary

@ntsummers1 ntsummers1 self-assigned this Oct 23, 2024
@ntsummers1 ntsummers1 added product review Waiting for product review do not merge Do not merge this pull request labels Oct 23, 2024
Copy link

codeclimate bot commented Oct 25, 2024

Code Climate has analyzed commit cf97c82 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 81.1% (0.0% change).

View more on Code Climate.

@ntsummers1 ntsummers1 added ready for review Ready for all the reviews! and removed do not merge Do not merge this pull request labels Oct 25, 2024
@ntsummers1 ntsummers1 marked this pull request as ready for review October 25, 2024 14:08
@ntsummers1 ntsummers1 changed the title Create ACS 2023 Seed Create ACS 2023 and FMAP 2025 Seed Oct 25, 2024
Copy link
Contributor

@gmrabian gmrabian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deployed branch looks good

values match tables

@ntsummers1 ntsummers1 merged commit f587192 into main Oct 25, 2024
20 checks passed
@ntsummers1 ntsummers1 deleted the update-acs-2023 branch October 25, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product review Waiting for product review ready for review Ready for all the reviews!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants