Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SASS and other UI related dependencies #139818

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

ntsummers1
Copy link
Collaborator

@ntsummers1 ntsummers1 commented Nov 12, 2024

Description

Properly fixes #139816

Updates SASS to 1.80.6 and migrates changes
Updates FontAwesome from 1.2 -> 6.6
Remove MaterialUI (Wasn't being used)
Updates date-fns from 3.6 -> 4.1
Updates jsonpath from 1.0.2 -> 1.1
Updates launchdarkley-sdk from 3.3.2 -> 3.6
Updates mathjs from 7.5 -> 13.2.1
Updates prop-types from 15.7.2 -> 15.8.1
Updates vite from 5.4.6 -> 5.4.11
Updates vite-tsconfig-paths from 4.3.2 -> 5.1.2 and migrates changes


How to test

Run the app and take a peek! Icons should show properly, data should save and load, and calculations (Like those in Section 2) should calculate correctly


Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

@ntsummers1 ntsummers1 added the draft Just a draft label Nov 12, 2024
@ntsummers1 ntsummers1 self-assigned this Nov 12, 2024
@ntsummers1 ntsummers1 changed the title Update sass dep to latest version Update SASS and other UI related dependencies Nov 12, 2024
@ntsummers1 ntsummers1 marked this pull request as ready for review November 13, 2024 15:59
@ntsummers1 ntsummers1 added ready for review Ready for all the reviews! and removed draft Just a draft labels Nov 13, 2024
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 5443 lines exceeds the maximum allowed for the inline comments feature.

Copy link

codeclimate bot commented Nov 14, 2024

Code Climate has analyzed commit 365e289 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 81.1% (0.0% change).

View more on Code Climate.

@gmrabian
Copy link
Contributor

what's the difference between this and #139821?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for all the reviews!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants