Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(banner): Banner for Subsequent Document Upload Release #1570

Merged
merged 5 commits into from
Jan 6, 2025

Conversation

andieswift
Copy link
Collaborator

@andieswift andieswift commented Dec 30, 2024

Story: https://jiraent.cms.gov/browse/OY2-31867
Endpoint: https://d2s15t18jolyzj.cloudfront.net/

Details

Create a banner in OneMAC so that when either a State or CMS user logs into the OneMAC system, the banner will appear to have nomenclature related to the new Subsequent Document Release.

Changes

  • removed launch darkly flag wrapper over the WHOLE notifications
  • Now NotificationAPI will always be called and then we will check if we hide/show a notification

Implementation Notes

  • I will have to run the lamda on each respective branch to see the new subdoc notification
  • I think we could make this code more bullet proof going forward. What if we add a new property to the notification type for the flags then on the frontend use that property to check if the notification shows/hides

Screenshot 2025-01-02 at 11 52 12 AM

Test Plan

  1. Log in as any user, check the home page has the notification
  2. check the user notification is displayed
  3. Try again with the enableSubsequentDocumentation flag turned off and check that the notification is NOT there

Copy link

Endpoint URL - Environment not yet deployed, delete this comment and run the Pull Request workflow again after deploy is complete

Copy link
Collaborator

@Dark-Knight-1313 Dark-Knight-1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Andi. looks good. I have one quick question. When you get a chance, ping me.

Also, I love your idea ( see below )

I think we could make this code more bullet proof going forward. What if we add a new property to the notification type for the flags then on the frontend use that property to check if the notification shows/hides

@andieswift andieswift merged commit 999ca29 into develop Jan 6, 2025
75 of 103 checks passed
@andieswift andieswift deleted the as-31867 branch January 6, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants