Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pentest 31462 #1586

Open
wants to merge 48 commits into
base: develop
Choose a base branch
from
Open

Pentest 31462 #1586

wants to merge 48 commits into from

Conversation

anyoussefinia
Copy link
Collaborator

Story: https://jiraent.cms.gov/browse/OY2-32701
Endpoint: https://d1qcvu24747qjj.cloudfront.net/

Details

admin users can visit the /profile/encoded-email page for any user. non admin users can only view other users with matching territories.

Changes

Pentesters identified that any user can visit the /profile/encoded-email page for any other user. Fix to block users that don't have permissions.

Test Plan

  1. Log in as an admin user and see that you can visit any other user page regardless of matching territores.
  2. Log in as non-admin user and verify that you can see another non-admin user with some matching territory.
  3. verify that non-admin user cannot view other users (admin or non admin) that do not have matching territories.

Copy link

github-actions bot commented Feb 6, 2025

Endpoint URL - https://d1qcvu24747qjj.cloudfront.net

@anyoussefinia
Copy link
Collaborator Author

screen-capture.16.webm

Copy link
Collaborator

@andieswift andieswift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getUserV2 is a confusing name, do you think you could either rename this file to match more of what you are doing or make this work part of getUser.js?

Also could you provide me with a user outside of MD so I can test if I can view them? I tried looking with the admin login but I still only see MD packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants